Merge pull request #890 from pikasTech/fix/v02-observability-sidecar-image
fix: keep v0.2 metrics sidecar on tools image
This commit is contained in:
@@ -902,6 +902,7 @@ function transformWorkloads({ workloads, deploy, catalog, source, sourceBranch =
|
||||
"hwlab.pikastech.local/rendered-by": "scripts/g14-gitops-render.mjs"
|
||||
});
|
||||
for (const container of podTemplate.spec.containers) {
|
||||
if (container.name === "hwlab-metrics") continue;
|
||||
const serviceId = serviceIdForWorkload(item, container);
|
||||
const deployService = deployServices.get(serviceId);
|
||||
if (!deployService) continue;
|
||||
|
||||
@@ -237,6 +237,7 @@ test("v02 render follows TypeScript runtime checks and does not self-patch boots
|
||||
assert.equal(workload.metadata.labels["hwlab.pikastech.local/monitoring"], "enabled");
|
||||
const sidecar = workload.spec.template.spec.containers.find((container) => container.name === "hwlab-metrics");
|
||||
assert.ok(sidecar, `missing metrics sidecar for ${serviceId}`);
|
||||
assert.match(sidecar.image, /hwlab-ci-node-tools:node22-alpine-bun-v1/u);
|
||||
assert.ok(sidecar.env.some((entry) => entry.name === "HWLAB_METRICS_SERVICE_ID" && entry.value === serviceId));
|
||||
assert.ok(sidecar.ports.some((port) => port.name === "metrics" && port.containerPort === 9100));
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user